GitHub

PR #142 · Add project search filters

Repository: harbor/project-console

Two changes in src/search/query.ts address the review feedback and the two reported typecheck errors. I’ve prepared the patch below. It has not been applied or tested, so the pull request is not ready for another review yet.

What needs fixing

• Empty searches: Mina’s review flagged that saved filters can load without a query. Calling query.trim() on an undefined value causes the reported TS18048 error. Blank input should also omit the q parameter entirely.
• Selected tags: Alex’s review flagged that sorting the original tags changes shared filter state. The array is typed as readonly string[], which also explains the reported TS2339 error: it has no mutating sort() method.

Proposed patch

In src/search/query.ts:

-const params = new URLSearchParams({ q: query.trim() });
+const params = new URLSearchParams();
+const q = query?.trim() ?? "";
+if (q) params.set("q", q);

-for (const tag of tags.sort()) {
+for (const tag of [...tags].sort()) {
   params.append("tag", tag);
 }

This keeps the existing alphabetical tag order in the URL, but sorts a copy so the selected chips keep their original order. It also trims a supplied query without adding an empty search parameter.

Checks before requesting review

Apply the patch, add these regression cases to the existing test suite, and rerun typecheck and the relevant tests. The supplied failure log ends with exit code 2; there is no passing run to confirm the fix yet.

Draft reviewer replies

Use these after applying and validating the patch:

• Mina: “Updated query handling to support undefined and blank input. The URL now omits q when there’s no search text.”
• Alex: “Updated tag sorting to work on a copy. URL ordering stays stable without changing the shared selection array.”

No changes have been pushed, and neither review thread has been resolved.